pinctrl: mvebu: make pdma clock on dove mandatory
authorSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Mon, 26 Nov 2012 19:16:39 +0000 (20:16 +0100)
committerJason Cooper <jason@lakedaemon.net>
Mon, 7 Jan 2013 16:19:02 +0000 (16:19 +0000)
With the ability to pass clocks through DT, now make the pdma
clock of dove pinctrl mandatory. Otherwise, pinctrl will hang
the system when accessing some registers.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/pinctrl/mvebu/pinctrl-dove.c

index 40c9c3eecd94560e4cc816dc1d1a2461d36616ef..9cc219f610002516ad07d0f58011b726f3ed7583 100644 (file)
@@ -595,8 +595,11 @@ static int __devinit dove_pinctrl_probe(struct platform_device *pdev)
         * grab clk to make sure it is ticking.
         */
        clk = devm_clk_get(&pdev->dev, NULL);
-       if (!IS_ERR(clk))
-               clk_prepare_enable(clk);
+       if (IS_ERR(clk)) {
+               dev_err(&pdev->dev, "Unable to get pdma clock");
+               return PTR_RET(clk);
+       }
+       clk_prepare_enable(clk);
 
        return mvebu_pinctrl_probe(pdev);
 }