net: bnxt: Remove Comparison to bool in bnxt_ethtool.c
authorJason Yan <yanaijie@huawei.com>
Tue, 5 May 2020 07:46:08 +0000 (15:46 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 May 2020 18:39:42 +0000 (11:39 -0700)
Fix the following coccicheck warning:

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1991:5-46: WARNING:
Comparison to bool
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:1993:10-54: WARNING:
Comparison to bool
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2380:5-38: WARNING:
Comparison to bool

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

index 07526868f7bee122d1c743378ac30fa55495ed12..dd0c3f227009217a3d01f55335c233b84ba53e2a 100644 (file)
@@ -2095,9 +2095,9 @@ static int bnxt_flash_firmware_from_file(struct net_device *dev,
                           rc, filename);
                return rc;
        }
-       if (bnxt_dir_type_is_ape_bin_format(dir_type) == true)
+       if (bnxt_dir_type_is_ape_bin_format(dir_type))
                rc = bnxt_flash_firmware(dev, dir_type, fw->data, fw->size);
-       else if (bnxt_dir_type_is_other_exec_format(dir_type) == true)
+       else if (bnxt_dir_type_is_other_exec_format(dir_type))
                rc = bnxt_flash_microcode(dev, dir_type, fw->data, fw->size);
        else
                rc = bnxt_flash_nvram(dev, dir_type, BNX_DIR_ORDINAL_FIRST,
@@ -2484,7 +2484,7 @@ static int bnxt_set_eeprom(struct net_device *dev,
        }
 
        /* Create or re-write an NVM item: */
-       if (bnxt_dir_type_is_executable(type) == true)
+       if (bnxt_dir_type_is_executable(type))
                return -EOPNOTSUPP;
        ext = eeprom->magic & 0xffff;
        ordinal = eeprom->offset >> 16;