bnxt_en: Failure to update PHY is not fatal condition.
authorMichael Chan <mchan@broadcom.com>
Sat, 20 Feb 2016 00:43:21 +0000 (19:43 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 20 Feb 2016 04:39:32 +0000 (23:39 -0500)
If we fail to update the PHY, we should print a warning and continue.
The current code to exit is buggy as it has not freed up the NIC
resources yet.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index 78f6b5a2b6a0f1d083fab8dc3f40e3629b6eea05..8ab000dd52d958317323c8486fc0538576727803 100644 (file)
@@ -4642,7 +4642,7 @@ static int __bnxt_open_nic(struct bnxt *bp, bool irq_re_init, bool link_re_init)
        if (link_re_init) {
                rc = bnxt_update_phy_setting(bp);
                if (rc)
-                       goto open_err;
+                       netdev_warn(bp->dev, "failed to update phy settings\n");
        }
 
        if (irq_re_init) {