mlxsw: spectrum_kvdl: use div_u64() for 64-bit division
authorArnd Bergmann <arnd@arndb.de>
Fri, 23 Feb 2018 13:15:31 +0000 (14:15 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Feb 2018 16:33:02 +0000 (11:33 -0500)
Calculating the number of entries now uses 64-bit arithmetic that
causes a link error on 32-bit architectures:

drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.o: In function `mlxsw_sp_kvdl_init':
spectrum_kvdl.c:(.text+0x51c): undefined reference to `__aeabi_uldivmod'

We could probably use a 32-bit division here as before, but since this is
not in a performance critical path, div_u64() seems cleaner here.

Fixes: 887839e6960d ("mlxsw: spectrum_kvdl: Add support for dynamic partition set")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c

index d27fa57ad3c36f83f7b641e0a958ffefab059f82..6fd701db90c9e951313fb4bf3b812006d18f0f1e 100644 (file)
@@ -278,7 +278,7 @@ static int mlxsw_sp_kvdl_part_init(struct mlxsw_sp *mlxsw_sp,
                resource_size = info->end_index - info->start_index + 1;
        }
 
-       nr_entries = resource_size / info->alloc_size;
+       nr_entries = div_u64(resource_size, info->alloc_size);
        usage_size = BITS_TO_LONGS(nr_entries) * sizeof(unsigned long);
        part = kzalloc(sizeof(*part) + usage_size, GFP_KERNEL);
        if (!part)