raid5: don't increment read_errors on EILSEQ return
authorNigel Croxon <ncroxon@redhat.com>
Fri, 6 Sep 2019 13:21:33 +0000 (09:21 -0400)
committerSong Liu <songliubraving@fb.com>
Fri, 13 Sep 2019 20:10:05 +0000 (13:10 -0700)
While MD continues to count read errors returned by the lower layer.
If those errors are -EILSEQ, instead of -EIO, it should NOT increase
the read_errors count.

When RAID6 is set up on dm-integrity target that detects massive
corruption, the leg will be ejected from the array.  Even if the
issue is correctable with a sector re-write and the array has
necessary redundancy to correct it.

The leg is ejected because it runs up the rdev->read_errors beyond
conf->max_nr_stripes.  The return status in dm-drypt when there is
a data integrity error is -EILSEQ (BLK_STS_PROTECTION).

Signed-off-by: Nigel Croxon <ncroxon@redhat.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
drivers/md/raid5.c

index da6a86e283184796cbaccd44f009f5a262354edd..8ea8443e09d5a5502f6acefad41f801a59e2bba6 100644 (file)
@@ -2526,7 +2526,8 @@ static void raid5_end_read_request(struct bio * bi)
                int set_bad = 0;
 
                clear_bit(R5_UPTODATE, &sh->dev[i].flags);
-               atomic_inc(&rdev->read_errors);
+               if (!(bi->bi_status == BLK_STS_PROTECTION))
+                       atomic_inc(&rdev->read_errors);
                if (test_bit(R5_ReadRepl, &sh->dev[i].flags))
                        pr_warn_ratelimited(
                                "md/raid:%s: read error on replacement device (sector %llu on %s).\n",