stating: gdm724x: remove explicit NULL comparison

This patch converts explicit NULL comparison to its shorter
equivalent form.
Done with coccinelle semantic patch:

@@
expression e;
@@

- e == NULL
+ !e

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
index 5efc588afec01b857f56c43b74fbcc68d6139c25..28107dd520d49e0644dee885a5618be9ae9c4200 100644 (file)
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging/gdm724x/gdm_lte.c
@@ -775,7 +775,7 @@ static int gdm_lte_receive_pkt(struct phy_dev *phy_dev, char *buf, int len)
                                   hci->cmd_evt);
 
        dev = phy_dev->dev[0];
-       if (dev == NULL)
+       if (!dev)
                return 0;
 
        switch (cmd_evt) {
@@ -938,7 +938,7 @@ void unregister_lte_device(struct phy_dev *phy_dev)
 
        for (index = 0; index < MAX_NIC_TYPE; index++) {
                net = phy_dev->dev[index];
-               if (net == NULL)
+               if (!net)
                        continue;
 
                unregister_netdev(net);

diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index e82f3179c5dbff6928e1fe6ead80206725d1ff0b..0408549ca994e12ebe8d59d74444c19345c0d402 100644 (file)
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -492,7 +492,7 @@ static int init_usb(struct mux_dev *mux_dev)
 
        for (i = 0; i < MAX_ISSUE_NUM * 2; i++) {
                r = alloc_mux_rx();
-               if (r == NULL) {
+               if (!r) {
                        ret = -ENOMEM;
                        break;
                }
@@ -662,7 +662,7 @@ static int __init gdm_usb_mux_init(void)
 {
 
        mux_rx_wq = create_workqueue("mux_rx_wq");
-       if (mux_rx_wq == NULL) {
+       if (!mux_rx_wq) {
                pr_err("work queue create fail\n");
                return -1;
        }

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 655f7688d03925a4796ff194298c922e89ae920b..ce5202ebaf1631fed8dd1680d6427342db614272 100644 (file)
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -88,7 +88,7 @@ static int gdm_tty_install(struct tty_driver *driver, struct tty_struct *tty)
 
        mutex_lock(&gdm_table_lock);
        gdm = gdm_table[i][j];
-       if (gdm == NULL) {
+       if (!gdm) {
                mutex_unlock(&gdm_table_lock);
                return -ENODEV;
        }

diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
index 1c15b9c80e4f3ffa67eef62ca61119174f11c6f5..f87dd6144c319cbb3b5728621a8f20a8fe73055b 100644 (file)
--- a/drivers/staging/gdm724x/gdm_usb.c
+++ b/drivers/staging/gdm724x/gdm_usb.c
@@ -338,7 +338,7 @@ static int init_usb(struct lte_udev *udev)
 
        for (i = 0; i < MAX_NUM_SDU_BUF; i++) {
                t_sdu = alloc_tx_sdu_struct();
-               if (t_sdu == NULL) {
+               if (!t_sdu) {
                        ret = -ENOMEM;
                        goto fail;
                }
@@ -349,7 +349,7 @@ static int init_usb(struct lte_udev *udev)
 
        for (i = 0; i < MAX_RX_SUBMIT_COUNT*2; i++) {
                r = alloc_rx_struct();
-               if (r == NULL) {
+               if (!r) {
                        ret = -ENOMEM;
                        goto fail;
                }
@@ -576,7 +576,7 @@ static int send_tx_packet(struct usb_device *usbdev, struct usb_tx *t, u32 len)
 {
        int ret = 0;
 
-       if (!(len%512))
+       if (!(len % 512))
                len++;
 
        usb_fill_bulk_urb(t->urb,
@@ -682,7 +682,7 @@ static void do_tx(struct work_struct *work)
                }
 
                t = alloc_tx_struct(TX_BUF_SIZE);
-               if (t == NULL) {
+               if (!t) {
                        spin_unlock_irqrestore(&tx->lock, flags);
                        return;
                }
@@ -732,7 +732,7 @@ static int gdm_usb_sdu_send(void *priv_dev, void *data, int len,
        t_sdu = get_tx_sdu_struct(tx, &no_spc);
        spin_unlock_irqrestore(&tx->lock, flags);
 
-       if (t_sdu == NULL) {
+       if (!t_sdu) {
                pr_err("sdu send - free list empty\n");
                return TX_NO_SPC;
        }
@@ -782,7 +782,7 @@ static int gdm_usb_hci_send(void *priv_dev, void *data, int len,
        }
 
        t = alloc_tx_struct(len);
-       if (t == NULL) {
+       if (!t) {
                pr_err("hci_send - out of memory\n");
                return -ENOMEM;
        }
@@ -1006,11 +1006,11 @@ static int __init gdm_usb_lte_init(void)
        }
 
        usb_tx_wq = create_workqueue("usb_tx_wq");
-       if (usb_tx_wq == NULL)
+       if (!usb_tx_wq)
                return -1;
 
        usb_rx_wq = create_workqueue("usb_rx_wq");
-       if (usb_rx_wq == NULL)
+       if (!usb_rx_wq)
                return -1;
 
        return usb_register(&gdm_usb_lte_driver);

diff --git a/drivers/staging/gdm724x/netlink_k.c b/drivers/staging/gdm724x/netlink_k.c
index 59a18304ef4a592830b3800ffcd4ecffb0903951..749dd60ab34f7e1592977b4e1e5c4030e9dc2bad 100644 (file)
--- a/drivers/staging/gdm724x/netlink_k.c
+++ b/drivers/staging/gdm724x/netlink_k.c
@@ -122,7 +122,7 @@ int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len)
        if (group > ND_MAX_GROUP)
                return -EINVAL;
 
-       if (!netlink_has_listeners(sock, group+1))
+       if (!netlink_has_listeners(sock, group + 1))
                return -ESRCH;
 
        skb = alloc_skb(NLMSG_SPACE(len), GFP_ATOMIC);