ubox: fix broken deferred start of logfile writer
authorDaniel Golle <daniel@makrotopia.org>
Mon, 31 Jan 2022 15:00:13 +0000 (15:00 +0000)
committerDaniel Golle <daniel@makrotopia.org>
Mon, 31 Jan 2022 15:03:25 +0000 (15:03 +0000)
Just use 'start' action which will have the desired effect instead of
trying to introduce a 'start_file' action which didn't work that way
because procd jshn magic would have to wrap around it.

Fixes: 88baf6ce2c ("ubox: only start log to file when filesystem has been mounted")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
package/system/ubox/files/log.init

index 6587cf6b0606e2cf567b88f00cb3844dd18d335f..c6fdf44292f538538abef419fb757b1593e402f9 100644 (file)
@@ -9,8 +9,6 @@ PIDCOUNT=0
 USE_PROCD=1
 PROG=/sbin/logread
 
-extra_command "start_file" "Start writing to log file"
-
 validate_log_section()
 {
        uci_load_validate system system "$1" "$2" \
@@ -90,7 +88,7 @@ start_service_remote()
 
 register_mount_trigger()
 {
-       [ -n "${log_file}" ] && procd_add_action_mount_trigger start_file "${log_file}"
+       [ -n "${log_file}" ] && procd_add_action_mount_trigger start "${log_file}"
 }
 
 service_triggers()
@@ -109,12 +107,6 @@ start_service()
        config_foreach validate_log_section system start_service_remote
 }
 
-start_file()
-{
-       config_load system
-       config_foreach validate_log_section system start_service_file
-}
-
 boot() {
        _BOOT=1 start
 }