clk: ti: dm814x: Add of_node_put() to prevent memory leak
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Sun, 4 Aug 2019 16:33:28 +0000 (22:03 +0530)
committerStephen Boyd <sboyd@kernel.org>
Wed, 7 Aug 2019 22:26:39 +0000 (15:26 -0700)
In function dm814x_adpll_early_init, variable np takes the value
returned by of_find_node_by_name, which gets a node but does not put it.
If np is not put before return, it may cause a memory leak. Hence put np
before return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lkml.kernel.org/r/20190804163328.6693-1-nishkadg.linux@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/ti/clk-814x.c

index e8cee6f3b4a0332742f84576d7ae373e4c09ca9a..087cfa75ac24846d5e9cd37bae040a4c333d49bb 100644 (file)
@@ -66,6 +66,7 @@ static int __init dm814x_adpll_early_init(void)
        }
 
        of_platform_populate(np, NULL, NULL, NULL);
+       of_node_put(np);
 
        return 0;
 }