Blackfin: bf54x: don't ack GPIO ints when unmasking them
authorMike Frysinger <vapier@gentoo.org>
Fri, 10 Dec 2010 20:42:59 +0000 (20:42 +0000)
committerMike Frysinger <vapier@gentoo.org>
Mon, 10 Jan 2011 12:18:26 +0000 (07:18 -0500)
When unmasking a GPIO interrupt on a BF54x part, the code will implicitly
ack any pending interrupts.  This is not what unmasking should do and can
cause people to miss interrupts from their devices, so punt the code.

Reported-by: Rutger Hofman <rutger@cs.vu.nl>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
arch/blackfin/mach-common/ints-priority.c

index da7e3c63746b465a8bb65b2321b3ca6ee783118c..a604f19d8dc315df316058942042ef7ee9f8b5b6 100644 (file)
@@ -866,7 +866,6 @@ static void bfin_gpio_unmask_irq(unsigned int irq)
        u32 pintbit = PINT_BIT(pint_val);
        u32 bank = PINT_2_BANK(pint_val);
 
-       pint[bank]->request = pintbit;
        pint[bank]->mask_set = pintbit;
 }