perf/x86/intel: Use update attributes for skylake format

Using the new pmu::update_attrs attribute group for
skylake specific format attributes.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190512155518.21468-9-jolsa@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>

diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index de4779f4473797e40a8dbb30fd2df4e94db27478..3bc967be7c7bdaf8698a7b36d4448570e0357082 100644 (file)
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -4453,6 +4453,11 @@ static struct attribute_group group_format_extra = {
        .is_visible = exra_is_visible,
 };
 
+static struct attribute_group group_format_extra_skl = {
+       .name       = "format",
+       .is_visible = exra_is_visible,
+};
+
 static const struct attribute_group *attr_update[] = {
        &group_events_td,
        &group_events_mem,
@@ -4460,6 +4465,7 @@ static const struct attribute_group *attr_update[] = {
        &group_caps_gen,
        &group_caps_lbr,
        &group_format_extra,
+       &group_format_extra_skl,
        NULL,
 };
 
@@ -4467,11 +4473,11 @@ static struct attribute *empty_attrs;
 
 __init int intel_pmu_init(void)
 {
+       struct attribute **extra_skl_attr = &empty_attrs;
        struct attribute **extra_attr = &empty_attrs;
        struct attribute **td_attr    = &empty_attrs;
        struct attribute **mem_attr   = &empty_attrs;
        struct attribute **tsx_attr   = &empty_attrs;
-       struct attribute **to_free = NULL;
        union cpuid10_edx edx;
        union cpuid10_eax eax;
        union cpuid10_ebx ebx;
@@ -4959,8 +4965,7 @@ __init int intel_pmu_init(void)
                x86_pmu.get_event_constraints = hsw_get_event_constraints;
                extra_attr = boot_cpu_has(X86_FEATURE_RTM) ?
                        hsw_format_attr : nhm_format_attr;
-               extra_attr = merge_attr(extra_attr, skl_format_attr);
-               to_free = extra_attr;
+               extra_skl_attr = skl_format_attr;
                td_attr  = hsw_events_attrs;
                mem_attr = hsw_mem_events_attrs;
                tsx_attr = hsw_tsx_events_attrs;
@@ -4998,7 +5003,7 @@ __init int intel_pmu_init(void)
                x86_pmu.get_event_constraints = icl_get_event_constraints;
                extra_attr = boot_cpu_has(X86_FEATURE_RTM) ?
                        hsw_format_attr : nhm_format_attr;
-               extra_attr = merge_attr(extra_attr, skl_format_attr);
+               extra_skl_attr = skl_format_attr;
                mem_attr = icl_events_attrs;
                tsx_attr = icl_tsx_events_attrs;
                x86_pmu.rtm_abort_event = X86_CONFIG(.event=0xca, .umask=0x02);
@@ -5033,6 +5038,7 @@ __init int intel_pmu_init(void)
        group_events_mem.attrs = mem_attr;
        group_events_tsx.attrs = tsx_attr;
        group_format_extra.attrs = extra_attr;
+       group_format_extra_skl.attrs = extra_skl_attr;
 
        x86_pmu.attr_update = attr_update;
 
@@ -5113,7 +5119,6 @@ __init int intel_pmu_init(void)
        if (x86_pmu.counter_freezing)
                x86_pmu.handle_irq = intel_pmu_handle_irq_v4;
 
-       kfree(to_free);
        return 0;
 }