net: Fix 'Re: PACKET_TX_RING: packet size is too long'
authorGabor Gombas <gombasg@sztaki.hu>
Thu, 29 Oct 2009 10:19:11 +0000 (03:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Oct 2009 10:19:11 +0000 (03:19 -0700)
Currently PACKET_TX_RING forces certain amount of every frame to remain
unused. This probably originates from an early version of the
PACKET_TX_RING patch that in fact used the extra space when the (since
removed) CONFIG_PACKET_MMAP_ZERO_COPY option was enabled. The current
code does not make any use of this extra space.

This patch removes the extra space reservation and lets userspace make
use of the full frame size.

Signed-off-by: Gabor Gombas <gombasg@sztaki.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c

index 1238949e66a99d603fdee2bf1060959c7e5030f8..48b18dad6763b45845b75cb2b852ce2b63273033 100644 (file)
@@ -982,10 +982,7 @@ static int tpacket_snd(struct packet_sock *po, struct msghdr *msg)
                goto out_put;
 
        size_max = po->tx_ring.frame_size
-               - sizeof(struct skb_shared_info)
-               - po->tp_hdrlen
-               - LL_ALLOCATED_SPACE(dev)
-               - sizeof(struct sockaddr_ll);
+               - (po->tp_hdrlen - sizeof(struct sockaddr_ll));
 
        if (size_max > dev->mtu + reserve)
                size_max = dev->mtu + reserve;