i40e/i40evf: Remove addressof casts to same type
authorJoe Perches <joe@perches.com>
Tue, 25 Mar 2014 04:30:32 +0000 (04:30 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 31 Mar 2014 22:48:02 +0000 (15:48 -0700)
Using addressof then casting to the original type is pointless,
so remove these unnecessary casts.

Done via coccinelle script:

$ cat typecast.cocci
@@
type T;
T foo;
@@

- (T *)&foo
+ &foo

Signed-off-by: Joe Perches <joe@perches.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_common.c
drivers/net/ethernet/intel/i40evf/i40e_common.c

index bb948dd924743f2305491a4836897116bdbaac30..922cdcc45c54b1d36de2a7c0b7faf0ed8cdf1e0d 100644 (file)
@@ -1775,9 +1775,9 @@ static void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,
        cap = (struct i40e_aqc_list_capabilities_element_resp *) buff;
 
        if (list_type_opc == i40e_aqc_opc_list_dev_capabilities)
-               p = (struct i40e_hw_capabilities *)&hw->dev_caps;
+               p = &hw->dev_caps;
        else if (list_type_opc == i40e_aqc_opc_list_func_capabilities)
-               p = (struct i40e_hw_capabilities *)&hw->func_caps;
+               p = &hw->func_caps;
        else
                return;
 
index c688a0fc5c2965a2ddf42d935b1fabd6902ace23..ae084378faabff7669794cd0f47a9072f1698243 100644 (file)
@@ -565,8 +565,7 @@ i40e_status i40e_aq_send_msg_to_pf(struct i40e_hw *hw,
                details.async = true;
                cmd_details = &details;
        }
-       status = i40evf_asq_send_command(hw, (struct i40e_aq_desc *)&desc, msg,
-                                      msglen, cmd_details);
+       status = i40evf_asq_send_command(hw, &desc, msg, msglen, cmd_details);
        return status;
 }