net: hns3: modify handling of out of memory in hclge_err.c
authorWeihang Li <liweihang@hisilicon.com>
Thu, 20 Jun 2019 08:52:40 +0000 (16:52 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Jun 2019 15:59:02 +0000 (11:59 -0400)
Users should be informed if HNS driver failed to allocate memory for
descriptor when handling hw errors. This patch solve above issues.

Signed-off-by: Weihang Li <liweihang@hisilicon.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c

index 3dfb265a3d54e1c51459579fde286a29bcc59d4f..dd7b8a8c7771ecfe1dde7ede8f854362daf28306 100644 (file)
@@ -1859,7 +1859,7 @@ static int hclge_handle_all_hw_msix_error(struct hclge_dev *hdev,
        if (ret) {
                dev_err(dev, "fail(%d) to query msix int status bd num\n",
                        ret);
-               return ret;
+               goto out;
        }
 
        mpf_bd_num = le32_to_cpu(desc_bd.data[0]);
@@ -1867,8 +1867,10 @@ static int hclge_handle_all_hw_msix_error(struct hclge_dev *hdev,
        bd_num = max_t(u32, mpf_bd_num, pf_bd_num);
 
        desc = kcalloc(bd_num, sizeof(struct hclge_desc), GFP_KERNEL);
-       if (!desc)
+       if (!desc) {
+               ret = -ENOMEM;
                goto out;
+       }
 
        ret = hclge_handle_mpf_msix_error(hdev, desc, mpf_bd_num,
                                          reset_requests);