drm/i915/gt: Drop stale commentary for timeline density
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 25 Jun 2019 23:33:48 +0000 (00:33 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 26 Jun 2019 06:25:52 +0000 (07:25 +0100)
We no longer allocate a contiguous set of timeline ids for all engines
upon creation, so we no longer should assume that the timelines are
densely allocated within a context. Hopefully, the set of fences used
within a workload are still dense enough for us to take advantage of
the compressed radix tree used for the syncmap.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190625233349.32371-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_timeline.c

index 47825827498679b82380f003d36b216e3d16cdc0..3bbb632cb535fb6942f8020c35eb69d59aecedb4 100644 (file)
@@ -210,16 +210,6 @@ int intel_timeline_init(struct intel_timeline *timeline,
 {
        void *vaddr;
 
-       /*
-        * Ideally we want a set of engines on a single leaf as we expect
-        * to mostly be tracking synchronisation between engines. It is not
-        * a huge issue if this is not the case, but we may want to mitigate
-        * any page crossing penalties if they become an issue.
-        *
-        * Called during early_init before we know how many engines there are.
-        */
-       BUILD_BUG_ON(KSYNCMAP < I915_NUM_ENGINES);
-
        timeline->gt = gt;
        timeline->pin_count = 0;
        timeline->has_initial_breadcrumb = !hwsp;