Tegra: pm: fix MISRA defects

Main fixes:

* Use int32_t replace int, use uint32_t replace unsign int
  [Rule 4.6]
* Add function define to header file [Rule 8.4]
* Added curly braces ({}) around if statements in order to
  make them compound [Rule 15.6]
* Voided non c-library functions whose return types are not used
  [Rule 17.7]

Change-Id: Ifa3ba4e75046697cfede885096bee9a30efe6519
Signed-off-by: Anthony Zhou <anzhou@nvidia.com>

diff --git a/plat/nvidia/tegra/common/tegra_pm.c b/plat/nvidia/tegra/common/tegra_pm.c
index ce44983b5f782da2083e03ea928fb2f7cb720bf4..626c23ed73a55e56006cd965fc5002a491e9915a 100644 (file)
--- a/plat/nvidia/tegra/common/tegra_pm.c
+++ b/plat/nvidia/tegra/common/tegra_pm.c
@@ -50,37 +50,42 @@ uint8_t tegra_fake_system_suspend;
 #pragma weak tegra_soc_prepare_system_off
 #pragma weak tegra_soc_get_target_pwr_state
 
-int tegra_soc_pwr_domain_suspend_pwrdown_early(const psci_power_state_t *target_state)
+int32_t tegra_soc_pwr_domain_suspend_pwrdown_early(const psci_power_state_t *target_state)
 {
        return PSCI_E_NOT_SUPPORTED;
 }
 
-int tegra_soc_pwr_domain_suspend(const psci_power_state_t *target_state)
+int32_t tegra_soc_pwr_domain_suspend(const psci_power_state_t *target_state)
 {
+       (void)target_state;
        return PSCI_E_NOT_SUPPORTED;
 }
 
-int tegra_soc_pwr_domain_on(u_register_t mpidr)
+int32_t tegra_soc_pwr_domain_on(u_register_t mpidr)
 {
+       (void)mpidr;
        return PSCI_E_SUCCESS;
 }
 
-int tegra_soc_pwr_domain_off(const psci_power_state_t *target_state)
+int32_t tegra_soc_pwr_domain_off(const psci_power_state_t *target_state)
 {
+       (void)target_state;
        return PSCI_E_SUCCESS;
 }
 
-int tegra_soc_pwr_domain_on_finish(const psci_power_state_t *target_state)
+int32_t tegra_soc_pwr_domain_on_finish(const psci_power_state_t *target_state)
 {
+       (void)target_state;
        return PSCI_E_SUCCESS;
 }
 
-int tegra_soc_pwr_domain_power_down_wfi(const psci_power_state_t *target_state)
+int32_t tegra_soc_pwr_domain_power_down_wfi(const psci_power_state_t *target_state)
 {
+       (void)target_state;
        return PSCI_E_SUCCESS;
 }
 
-int tegra_soc_prepare_system_reset(void)
+int32_t tegra_soc_prepare_system_reset(void)
 {
        return PSCI_E_SUCCESS;
 }
@@ -91,19 +96,26 @@ __dead2 void tegra_soc_prepare_system_off(void)
        panic();
 }
 
-plat_local_state_t tegra_soc_get_target_pwr_state(unsigned int lvl,
+plat_local_state_t tegra_soc_get_target_pwr_state(uint32_t lvl,
                                             const plat_local_state_t *states,
-                                            unsigned int ncpu)
+                                            uint32_t ncpu)
 {
        plat_local_state_t target = PLAT_MAX_OFF_STATE, temp;
+       uint32_t num_cpu = ncpu;
+       const plat_local_state_t *local_state = states;
+
+       (void)lvl;
 
        assert(ncpu);
 
        do {
-               temp = *states++;
-               if ((temp < target))
+               temp = *local_state;
+               if ((temp < target)) {
                        target = temp;
-       } while (--ncpu);
+               }
+               --num_cpu;
+               local_state++;
+       } while (num_cpu != 0U);
 
        return target;
 }
@@ -117,8 +129,9 @@ plat_local_state_t tegra_soc_get_target_pwr_state(unsigned int lvl,
 void tegra_get_sys_suspend_power_state(psci_power_state_t *req_state)
 {
        /* all affinities use system suspend state id */
-       for (uint32_t i = MPIDR_AFFLVL0; i <= PLAT_MAX_PWR_LVL; i++)
+       for (uint32_t i = MPIDR_AFFLVL0; i <= PLAT_MAX_PWR_LVL; i++) {
                req_state->pwr_domain_state[i] = PSTATE_ID_SOC_POWERDN;
+       }
 }
 
 /*******************************************************************************
@@ -126,6 +139,8 @@ void tegra_get_sys_suspend_power_state(psci_power_state_t *req_state)
  ******************************************************************************/
 void tegra_cpu_standby(plat_local_state_t cpu_state)
 {
+       (void)cpu_state;
+
        /*
         * Enter standby state
         * dsb is good practice before using wfi to enter low power states
@@ -138,7 +153,7 @@ void tegra_cpu_standby(plat_local_state_t cpu_state)
  * Handler called when an affinity instance is about to be turned on. The
  * level and mpidr determine the affinity instance.
  ******************************************************************************/
-int tegra_pwr_domain_on(u_register_t mpidr)
+int32_t tegra_pwr_domain_on(u_register_t mpidr)
 {
        return tegra_soc_pwr_domain_on(mpidr);
 }
@@ -149,7 +164,7 @@ int tegra_pwr_domain_on(u_register_t mpidr)
  ******************************************************************************/
 void tegra_pwr_domain_off(const psci_power_state_t *target_state)
 {
-       tegra_soc_pwr_domain_off(target_state);
+       (void)tegra_soc_pwr_domain_off(target_state);
 }
 
 /*******************************************************************************
@@ -169,12 +184,13 @@ void tegra_pwr_domain_suspend_pwrdown_early(const psci_power_state_t *target_sta
  ******************************************************************************/
 void tegra_pwr_domain_suspend(const psci_power_state_t *target_state)
 {
-       tegra_soc_pwr_domain_suspend(target_state);
+       (void)tegra_soc_pwr_domain_suspend(target_state);
 
        /* Disable console if we are entering deep sleep. */
        if (target_state->pwr_domain_state[PLAT_MAX_PWR_LVL] ==
-                       PSTATE_ID_SOC_POWERDN)
-               console_uninit();
+                       PSTATE_ID_SOC_POWERDN) {
+               (void)console_uninit();
+       }
 
        /* disable GICC */
        tegra_gic_cpuif_deactivate();
@@ -191,7 +207,7 @@ __dead2 void tegra_pwr_domain_power_down_wfi(const psci_power_state_t
        uint64_t rmr_el3 = 0;
 
        /* call the chip's power down handler */
-       tegra_soc_pwr_domain_power_down_wfi(target_state);
+       (void)tegra_soc_pwr_domain_power_down_wfi(target_state);
 
        /*
         * If we are in fake system suspend mode, ensure we start doing
@@ -222,7 +238,7 @@ __dead2 void tegra_pwr_domain_power_down_wfi(const psci_power_state_t
  ******************************************************************************/
 void tegra_pwr_domain_on_finish(const psci_power_state_t *target_state)
 {
-       plat_params_from_bl2_t *plat_params;
+       const plat_params_from_bl2_t *plat_params;
        uint32_t console_clock;
 
        /*
@@ -239,15 +255,15 @@ void tegra_pwr_domain_on_finish(const psci_power_state_t *target_state)
                /*
                 * Reference clock used by the FPGAs is a lot slower.
                 */
-               if (tegra_platform_is_fpga() == 1U) {
+               if (tegra_platform_is_fpga()) {
                        console_clock = TEGRA_BOOT_UART_CLK_13_MHZ;
                } else {
                        console_clock = TEGRA_BOOT_UART_CLK_408_MHZ;
                }
 
                /* Initialize the runtime console */
-               if (tegra_console_base != (uint64_t)0) {
-                       console_init(tegra_console_base, console_clock,
+               if (tegra_console_base != 0ULL) {
+                       (void)console_init(tegra_console_base, console_clock,
                                     TEGRA_CONSOLE_BAUDRATE);
                }
 
@@ -262,7 +278,7 @@ void tegra_pwr_domain_on_finish(const psci_power_state_t *target_state)
                 */
                plat_params = bl31_get_plat_params();
                tegra_memctrl_tzdram_setup(plat_params->tzdram_base,
-                       plat_params->tzdram_size);
+                       (uint32_t)plat_params->tzdram_size);
 
                /*
                 * Set up the TZRAM memory aperture to allow only secure world
@@ -274,7 +290,7 @@ void tegra_pwr_domain_on_finish(const psci_power_state_t *target_state)
        /*
         * Reset hardware settings.
         */
-       tegra_soc_pwr_domain_on_finish(target_state);
+       (void)tegra_soc_pwr_domain_on_finish(target_state);
 }
 
 /*******************************************************************************
@@ -305,7 +321,7 @@ __dead2 void tegra_system_reset(void)
        INFO("Restarting system...\n");
 
        /* per-SoC system reset handler */
-       tegra_soc_prepare_system_reset();
+       (void)tegra_soc_prepare_system_reset();
 
        /*
         * Program the PMC in order to restart the system.
@@ -316,7 +332,7 @@ __dead2 void tegra_system_reset(void)
 /*******************************************************************************
  * Handler called to check the validity of the power state parameter.
  ******************************************************************************/
-int32_t tegra_validate_power_state(unsigned int power_state,
+int32_t tegra_validate_power_state(uint32_t power_state,
                                   psci_power_state_t *req_state)
 {
        assert(req_state);
@@ -327,16 +343,19 @@ int32_t tegra_validate_power_state(unsigned int power_state,
 /*******************************************************************************
  * Platform handler called to check the validity of the non secure entrypoint.
  ******************************************************************************/
-int tegra_validate_ns_entrypoint(uintptr_t entrypoint)
+int32_t tegra_validate_ns_entrypoint(uintptr_t entrypoint)
 {
+       int32_t ret = PSCI_E_INVALID_ADDRESS;
+
        /*
         * Check if the non secure entrypoint lies within the non
         * secure DRAM.
         */
-       if ((entrypoint >= TEGRA_DRAM_BASE) && (entrypoint <= TEGRA_DRAM_END))
-               return PSCI_E_SUCCESS;
+       if ((entrypoint >= TEGRA_DRAM_BASE) && (entrypoint <= TEGRA_DRAM_END)) {
+               ret = PSCI_E_SUCCESS;
+       }
 
-       return PSCI_E_INVALID_ADDRESS;
+       return ret;
 }
 
 /*******************************************************************************
@@ -376,7 +395,7 @@ int plat_setup_psci_ops(uintptr_t sec_entrypoint,
        /*
         * Reset hardware settings.
         */
-       tegra_soc_pwr_domain_on_finish(&target_state);
+       (void)tegra_soc_pwr_domain_on_finish(&target_state);
 
        /*
         * Initialize PSCI ops struct

diff --git a/plat/nvidia/tegra/include/tegra_private.h b/plat/nvidia/tegra/include/tegra_private.h
index a9abbf34844e35fac26f83f30c95408a18f41a94..ff1bd50d90ad0c3c45f61fd86079e282af1257ed 100644 (file)
--- a/plat/nvidia/tegra/include/tegra_private.h
+++ b/plat/nvidia/tegra/include/tegra_private.h
@@ -82,7 +82,30 @@ extern uint8_t tegra_fake_system_suspend;
 
 void tegra_pm_system_suspend_entry(void);
 void tegra_pm_system_suspend_exit(void);
-int tegra_system_suspended(void);
+int32_t tegra_system_suspended(void);
+int32_t tegra_soc_pwr_domain_suspend(const psci_power_state_t *target_state);
+int32_t tegra_soc_pwr_domain_on(u_register_t mpidr);
+int32_t tegra_soc_pwr_domain_off(const psci_power_state_t *target_state);
+int32_t tegra_soc_pwr_domain_on_finish(const psci_power_state_t *target_state);
+int32_t tegra_soc_pwr_domain_power_down_wfi(const psci_power_state_t *target_state);
+int32_t tegra_soc_prepare_system_reset(void);
+__dead2 void tegra_soc_prepare_system_off(void);
+plat_local_state_t tegra_soc_get_target_pwr_state(uint32_t lvl,
+                                            const plat_local_state_t *states,
+                                            uint32_t ncpu);
+void tegra_get_sys_suspend_power_state(psci_power_state_t *req_state);
+void tegra_cpu_standby(plat_local_state_t cpu_state);
+int32_t tegra_pwr_domain_on(u_register_t mpidr);
+void tegra_pwr_domain_off(const psci_power_state_t *target_state);
+void tegra_pwr_domain_suspend(const psci_power_state_t *target_state);
+void __dead2 tegra_pwr_domain_power_down_wfi(const psci_power_state_t *target_state);
+void tegra_pwr_domain_on_finish(const psci_power_state_t *target_state);
+void tegra_pwr_domain_suspend_finish(const psci_power_state_t *target_state);
+__dead2 void tegra_system_off(void);
+__dead2 void tegra_system_reset(void);
+int32_t tegra_validate_power_state(uint32_t power_state,
+                                  psci_power_state_t *req_state);
+int32_t tegra_validate_ns_entrypoint(uintptr_t entrypoint);
 
 /* Declarations for tegraXXX_pm.c */
 int tegra_prepare_cpu_suspend(unsigned int id, unsigned int afflvl);