Input: uinput - use monotonic times for timestamps
authorDeepa Dinamani <deepa.kernel@gmail.com>
Tue, 2 Jan 2018 06:27:11 +0000 (22:27 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 2 Jan 2018 06:54:42 +0000 (22:54 -0800)
struct timeval which is part of struct input_event to maintain the event
times is not y2038 safe.

Real time timestamps are also not ideal for input_event as this time can go
backwards as noted in the patch a80b83b7b8 by John Stultz.

The patch switches the timestamps to use monotonic time from realtime time.
This is assuming no one is using absolute times from these timestamps.

The structure to maintain input events will be changed in a different
patch.

Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
Patchwork-Id: 10118255
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/uinput.c

index 39ddd9a73febb7f4c3d9b70d9422afcc51c42f02..d521aecbc0783b2c6cd9f6380bbcd76f3ada7a26 100644 (file)
@@ -84,11 +84,14 @@ static int uinput_dev_event(struct input_dev *dev,
                            unsigned int type, unsigned int code, int value)
 {
        struct uinput_device    *udev = input_get_drvdata(dev);
+       struct timespec64       ts;
 
        udev->buff[udev->head].type = type;
        udev->buff[udev->head].code = code;
        udev->buff[udev->head].value = value;
-       do_gettimeofday(&udev->buff[udev->head].time);
+       ktime_get_ts64(&ts);
+       udev->buff[udev->head].time.tv_sec = ts.tv_sec;
+       udev->buff[udev->head].time.tv_usec = ts.tv_nsec / NSEC_PER_USEC;
        udev->head = (udev->head + 1) % UINPUT_BUFFER_SIZE;
 
        wake_up_interruptible(&udev->waitq);