media: dibx000_common: use strlcpy() instead of strncpy()
authorXiongfeng Wang <xiongfeng.wang@linaro.org>
Mon, 8 Jan 2018 12:52:34 +0000 (07:52 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Mar 2018 11:05:53 +0000 (06:05 -0500)
gcc-8 reports

drivers/media/dvb-frontends/dibx000_common.c: In function
'i2c_adapter_init':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 48 equals destination size [-Wstringop-truncation]

We need to use strlcpy() to make sure the dest string is
nul-terminated.

Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/dibx000_common.c

index d981233e458f9d60b25fc4d229f456b82d2816f7..70119c79ac2b41900daabc678c28795cea081867 100644 (file)
@@ -424,7 +424,7 @@ static int i2c_adapter_init(struct i2c_adapter *i2c_adap,
                                struct i2c_algorithm *algo, const char *name,
                                struct dibx000_i2c_master *mst)
 {
-       strncpy(i2c_adap->name, name, sizeof(i2c_adap->name));
+       strlcpy(i2c_adap->name, name, sizeof(i2c_adap->name));
        i2c_adap->algo = algo;
        i2c_adap->algo_data = NULL;
        i2c_set_adapdata(i2c_adap, mst);