drm/exynos: check for null pointers in error handling
authorPaul Taysom <taysom@chromium.org>
Fri, 9 May 2014 06:06:28 +0000 (15:06 +0900)
committerInki Dae <daeinki@gmail.com>
Sun, 1 Jun 2014 17:07:07 +0000 (02:07 +0900)
Smatch error from arm build: drivers/gpu/drm/exynos/
exynos_hdmi.c:2374 hdmi_probe() error: potential NULL
dereference 'hdata->hdmiphy_port'.

Added check for hdata->hdmiphy_port that it is not NULL.

Signed-off-by: Paul Taysom <taysom@chromium.org>
Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_hdmi.c

index 73a7acb1283c46d1022e4b556ed13e3f4a36b841..0dc9e3c9d10306188a3d8711969ad1eea69af964 100644 (file)
@@ -2174,7 +2174,8 @@ static int hdmi_probe(struct platform_device *pdev)
        return exynos_drm_component_add(&pdev->dev, &hdmi_component_ops);
 
 err_hdmiphy:
-       put_device(&hdata->hdmiphy_port->dev);
+       if (hdata->hdmiphy_port)
+               put_device(&hdata->hdmiphy_port->dev);
 err_ddc:
        put_device(&hdata->ddc_adpt->dev);
        return ret;