ALSA: firewire: constify snd_pcm_ops structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 18 Aug 2017 07:45:13 +0000 (13:15 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sat, 19 Aug 2017 09:02:17 +0000 (11:02 +0200)
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/isight.c
sound/firewire/motu/motu-pcm.c

index 48d6dca471c6bc5713cd7a6ee7bc466c008a1997..5826aa8362f10b319c5946054c73107fef5f963f 100644 (file)
@@ -444,7 +444,7 @@ static snd_pcm_uframes_t isight_pointer(struct snd_pcm_substream *substream)
 
 static int isight_create_pcm(struct isight *isight)
 {
-       static struct snd_pcm_ops ops = {
+       static const struct snd_pcm_ops ops = {
                .open      = isight_open,
                .close     = isight_close,
                .ioctl     = snd_pcm_lib_ioctl,
index a2b50df708743f4fce0f16303ac195a3e33ea512..1466e46a101eb387d3693638ea4b1bb4347d826f 100644 (file)
@@ -352,7 +352,7 @@ static int playback_ack(struct snd_pcm_substream *substream)
 
 int snd_motu_create_pcm_devices(struct snd_motu *motu)
 {
-       static struct snd_pcm_ops capture_ops = {
+       static const struct snd_pcm_ops capture_ops = {
                .open      = pcm_open,
                .close     = pcm_close,
                .ioctl     = snd_pcm_lib_ioctl,
@@ -365,7 +365,7 @@ int snd_motu_create_pcm_devices(struct snd_motu *motu)
                .page      = snd_pcm_lib_get_vmalloc_page,
                .mmap      = snd_pcm_lib_mmap_vmalloc,
        };
-       static struct snd_pcm_ops playback_ops = {
+       static const struct snd_pcm_ops playback_ops = {
                .open      = pcm_open,
                .close     = pcm_close,
                .ioctl     = snd_pcm_lib_ioctl,