net: dsa: mv88e6xxx: fix boolreturn.cocci warnings
authorFengguang Wu <fengguang.wu@intel.com>
Tue, 6 Mar 2018 15:54:07 +0000 (23:54 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Mar 2018 18:33:23 +0000 (13:33 -0500)
drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
CC: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/serdes.c

index 4756969c154629eebb9ff108eba4bf641f005d67..b6166424216a74120de572209ac066fe84d2a834 100644 (file)
@@ -63,15 +63,15 @@ static bool mv88e6352_port_has_serdes(struct mv88e6xxx_chip *chip, int port)
        err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
        if (err) {
                dev_err(chip->dev, "failed to read cmode\n");
-               return 0;
+               return false;
        }
 
        if ((cmode == MV88E6XXX_PORT_STS_CMODE_100BASE_X) ||
            (cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
            (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII))
-               return 1;
+               return true;
 
-       return 0;
+       return false;
 }
 
 int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)