block: update print_req_error()
authorChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Thu, 20 Jun 2019 17:59:18 +0000 (10:59 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 20 Jun 2019 19:03:51 +0000 (13:03 -0600)
Improve the print_req_error with additional request fields which are
helpful for debugging. Use newly introduced blk_op_str() to print the
REQ_OP_XXX in the string format.

Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c

index 129204dd3bae9b366ceaab29ce0aa0994e2d8fe9..5d1fc8e17dd168a7e2723b2a90699491ccad06bd 100644 (file)
@@ -212,11 +212,14 @@ static void print_req_error(struct request *req, blk_status_t status,
                return;
 
        printk_ratelimited(KERN_ERR
-               "%s: %s error, dev %s, sector %llu op 0x%x flags 0x%x\n",
+               "%s: %s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
+               "phys_seg %u prio class %u\n",
                caller, blk_errors[idx].name,
-               req->rq_disk ?  req->rq_disk->disk_name : "?",
-               blk_rq_pos(req), req_op(req),
-               req->cmd_flags & ~REQ_OP_MASK);
+               req->rq_disk ? req->rq_disk->disk_name : "?",
+               blk_rq_pos(req), req_op(req), blk_op_str(req_op(req)),
+               req->cmd_flags & ~REQ_OP_MASK,
+               req->nr_phys_segments,
+               IOPRIO_PRIO_CLASS(req->ioprio));
 }
 
 static void req_bio_endio(struct request *rq, struct bio *bio,