sysauth: add autocomplete and id attributes to login inputs

this let browser automatically fill according to HTML spec for input elements.
luci-theme-bootstrap and luci-base are affected.

Signed-off-by: Viktor Tsvetkov <zwetvik@gmail.com>
[indentation fix]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 3e9d9a9dbb045c24eb93643838f8e8e3b9074e4b)

diff --git a/modules/luci-base/luasrc/view/sysauth.htm b/modules/luci-base/luasrc/view/sysauth.htm
index acd5ff7e38f9c3c407958a3249c85ffa61115e37..797c87a72ee4ffdd52d7e6ac9eefff396a75e5af 100644 (file)
--- a/modules/luci-base/luasrc/view/sysauth.htm
+++ b/modules/luci-base/luasrc/view/sysauth.htm
@@ -20,15 +20,15 @@
                </div>
                <div class="cbi-section"><div class="cbi-section-node">
                        <div class="cbi-value">
-                               <label class="cbi-value-title"><%:Username%></label>
+                               <label class="cbi-value-title" for="luci_username"><%:Username%></label>
                                <div class="cbi-value-field">
-                                       <input class="cbi-input-text" type="text" name="luci_username" value="<%=duser%>" />
+                                       <input class="cbi-input-text" type="text" name="luci_username" id="luci_username" autocomplete="username" value="<%=duser%>" />
                                </div>
                        </div>
                        <div class="cbi-value cbi-value-last">
-                               <label class="cbi-value-title"><%:Password%></label>
+                               <label class="cbi-value-title" for="luci_password"><%:Password%></label>
                                <div class="cbi-value-field">
-                                       <input class="cbi-input-text" type="password" name="luci_password" />
+                                       <input class="cbi-input-text" type="password" name="luci_password" id="luci_password" autocomplete="current-password"/>
                                </div>
                        </div>
                </div></div>

diff --git a/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm b/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm
index 8a97bbd104d87cf0c53d08c0abb8a7b41e01d3a9..72b04783bbf9ccb46c5be9b2f92488b0709dc0e7 100644 (file)
--- a/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm
+++ b/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/sysauth.htm
@@ -17,13 +17,13 @@
                                <div class="cbi-value">
                                        <label class="cbi-value-title" for="luci_username"><%:Username%></label>
                                        <div class="cbi-value-field">
-                                               <input name="luci_username" type="text"<%=attr("value", duser)%>>
+                                               <input name="luci_username" id="luci_username" type="text" autocomplete="username" <%=attr("value", duser)%>>
                                        </div>
                                </div>
                                <div class="cbi-value">
                                        <label class="cbi-value-title" for="luci_password"><%:Password%></label>
                                        <div class="cbi-value-field">
-                                               <input name="luci_password" type="password">
+                                               <input name="luci_password" id="luci_password" type="password" autocomplete="current-password">
                                        </div>
                                </div>
                        </div>