Staging: irda: Use !x instead of NULL comparison
authorSrishti Sharma <srishtishar@gmail.com>
Sat, 16 Sep 2017 06:34:27 +0000 (12:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Sep 2017 09:53:16 +0000 (11:53 +0200)
Test for NULL as !x where functions that return NULL on failure
are used. Done using the following semantic patch by coccinelle.

@ is_null @
expression E;
statement S;
@@

E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|
usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));

(
if(!E)
   S
|
-if(E==NULL)
+if(!E)
    S
)

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/irda/net/discovery.c

index 364d70aed068d8bcec4aa3d43e2314472aef307f..1e54954a4081047cc63c8e9c2a2b74346a797202 100644 (file)
@@ -179,7 +179,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force)
                                /* Create the client specific buffer */
                                n = HASHBIN_GET_SIZE(log);
                                buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC);
-                               if (buffer == NULL) {
+                               if (!buffer) {
                                        spin_unlock_irqrestore(&log->hb_spinlock, flags);
                                        return;
                                }
@@ -291,7 +291,7 @@ struct irda_device_info *irlmp_copy_discoveries(hashbin_t *log, int *pn,
                                /* Create the client specific buffer */
                                n = HASHBIN_GET_SIZE(log);
                                buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC);
-                               if (buffer == NULL) {
+                               if (!buffer) {
                                        spin_unlock_irqrestore(&log->hb_spinlock, flags);
                                        return NULL;
                                }