wimax/i2400m: move i2400m_init() out of i2400m.h
authorInaky Perez-Gonzalez <inaky@linux.intel.com>
Wed, 7 Oct 2009 12:37:53 +0000 (21:37 +0900)
committerInaky Perez-Gonzalez <inaky@linux.intel.com>
Mon, 19 Oct 2009 06:56:19 +0000 (15:56 +0900)
Upcoming changes will have to add things to this function that expose
more internals, which would mean more forward declarators.

Frankly, it doesn't need to be an inline, so moved to driver.c, where
the declarations will be taken from the header file.

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
drivers/net/wimax/i2400m/driver.c
drivers/net/wimax/i2400m/i2400m.h

index 10673af5a7f0f0f0b951ba635f474878e8023bf5..9b78e059563d8f90633573db5936fcfe0712971a 100644 (file)
@@ -848,6 +848,36 @@ void i2400m_bm_buf_free(struct i2400m *i2400m)
 }
 
 
+/**
+ * i2400m_init - Initialize a 'struct i2400m' from all zeroes
+ *
+ * This is a bus-generic API call.
+ */
+void i2400m_init(struct i2400m *i2400m)
+{
+       wimax_dev_init(&i2400m->wimax_dev);
+
+       i2400m->boot_mode = 1;
+       i2400m->rx_reorder = 1;
+       init_waitqueue_head(&i2400m->state_wq);
+
+       spin_lock_init(&i2400m->tx_lock);
+       i2400m->tx_pl_min = UINT_MAX;
+       i2400m->tx_size_min = UINT_MAX;
+
+       spin_lock_init(&i2400m->rx_lock);
+       i2400m->rx_pl_min = UINT_MAX;
+       i2400m->rx_size_min = UINT_MAX;
+
+       mutex_init(&i2400m->msg_mutex);
+       init_completion(&i2400m->msg_completion);
+
+       mutex_init(&i2400m->init_mutex);
+       /* wake_tx_ws is initialized in i2400m_tx_setup() */
+}
+EXPORT_SYMBOL_GPL(i2400m_init);
+
+
 /**
  * i2400m_setup - bus-generic setup function for the i2400m device
  *
index f5ed7d5cee47ed12fa32aa76e282675985fda755..4f8815d8887475dd3e58106db8077736971e6b06 100644 (file)
@@ -575,36 +575,6 @@ struct i2400m {
 };
 
 
-/*
- * Initialize a 'struct i2400m' from all zeroes
- *
- * This is a bus-generic API call.
- */
-static inline
-void i2400m_init(struct i2400m *i2400m)
-{
-       wimax_dev_init(&i2400m->wimax_dev);
-
-       i2400m->boot_mode = 1;
-       i2400m->rx_reorder = 1;
-       init_waitqueue_head(&i2400m->state_wq);
-
-       spin_lock_init(&i2400m->tx_lock);
-       i2400m->tx_pl_min = UINT_MAX;
-       i2400m->tx_size_min = UINT_MAX;
-
-       spin_lock_init(&i2400m->rx_lock);
-       i2400m->rx_pl_min = UINT_MAX;
-       i2400m->rx_size_min = UINT_MAX;
-
-       mutex_init(&i2400m->msg_mutex);
-       init_completion(&i2400m->msg_completion);
-
-       mutex_init(&i2400m->init_mutex);
-       /* wake_tx_ws is initialized in i2400m_tx_setup() */
-}
-
-
 /*
  * Bus-generic internal APIs
  * -------------------------
@@ -737,6 +707,7 @@ unsigned i2400m_brh_get_signature(const struct i2400m_bootrom_header *hdr)
 /*
  * Driver / device setup and internal functions
  */
+extern void i2400m_init(struct i2400m *);
 extern void i2400m_netdev_setup(struct net_device *net_dev);
 extern int i2400m_sysfs_setup(struct device_driver *);
 extern void i2400m_sysfs_release(struct device_driver *);