drm/i915: Clean up DSC vs. not bpp handling
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 26 Mar 2019 14:49:03 +0000 (16:49 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 11 Apr 2019 18:22:40 +0000 (21:22 +0300)
No point in duplicating all this code when we can just
use a variable to hold the output bpp (the only thing
that differs between the two branches).

Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.comk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190326144903.6617-2-ville.syrjala@linux.intel.com
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
drivers/gpu/drm/i915/intel_dp.c

index 6f1babe911df0ef2caa2db0922c90778d9590fe1..e0c59383d11ecdeabf4381e47e873dbae4613ff3 100644 (file)
@@ -2111,7 +2111,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
                to_intel_digital_connector_state(conn_state);
        bool constant_n = drm_dp_has_quirk(&intel_dp->desc,
                                           DP_DPCD_QUIRK_CONSTANT_N);
-       int ret;
+       int ret, output_bpp;
 
        if (HAS_PCH_SPLIT(dev_priv) && !HAS_DDI(dev_priv) && port != PORT_A)
                pipe_config->has_pch_encoder = true;
@@ -2166,25 +2166,22 @@ intel_dp_compute_config(struct intel_encoder *encoder,
        pipe_config->limited_color_range =
                intel_dp_limited_color_range(pipe_config, conn_state);
 
-       if (!pipe_config->dsc_params.compression_enable)
-               intel_link_compute_m_n(pipe_config->pipe_bpp,
-                                      pipe_config->lane_count,
-                                      adjusted_mode->crtc_clock,
-                                      pipe_config->port_clock,
-                                      &pipe_config->dp_m_n,
-                                      constant_n);
+       if (pipe_config->dsc_params.compression_enable)
+               output_bpp = pipe_config->dsc_params.compressed_bpp;
        else
-               intel_link_compute_m_n(pipe_config->dsc_params.compressed_bpp,
-                                      pipe_config->lane_count,
-                                      adjusted_mode->crtc_clock,
-                                      pipe_config->port_clock,
-                                      &pipe_config->dp_m_n,
-                                      constant_n);
+               output_bpp = pipe_config->pipe_bpp;
+
+       intel_link_compute_m_n(output_bpp,
+                              pipe_config->lane_count,
+                              adjusted_mode->crtc_clock,
+                              pipe_config->port_clock,
+                              &pipe_config->dp_m_n,
+                              constant_n);
 
        if (intel_connector->panel.downclock_mode != NULL &&
                dev_priv->drrs.type == SEAMLESS_DRRS_SUPPORT) {
                        pipe_config->has_drrs = true;
-                       intel_link_compute_m_n(pipe_config->pipe_bpp,
+                       intel_link_compute_m_n(output_bpp,
                                               pipe_config->lane_count,
                                               intel_connector->panel.downclock_mode->clock,
                                               pipe_config->port_clock,