ravb: Decrease TxFIFO depth of Q3 and Q2 to one
authorMasaru Nagai <masaru.nagai.vx@renesas.com>
Thu, 7 Mar 2019 10:24:47 +0000 (11:24 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Mar 2019 17:31:05 +0000 (09:31 -0800)
Hardware has the CBS (Credit Based Shaper) which affects only Q3
and Q2. When updating the CBS settings, even if the driver does so
after waiting for Tx DMA finished, there is a possibility that frame
data still remains in TxFIFO.

To avoid this, decrease TxFIFO depth of Q3 and Q2 to one.

This patch has been exercised this using netperf TCP_MAERTS, TCP_STREAM
and UDP_STREAM tests run on an Ebisu board. No performance change was
detected, outside of noise in the tests, both in terms of throughput and
CPU utilisation.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[simon: updated changelog]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c

index d28c8f9ca55ba31bacbd0f96e0538616621da14f..8154b38c08f717f39adb1c5255493d5f0373a6ee 100644 (file)
@@ -458,7 +458,7 @@ static int ravb_dmac_init(struct net_device *ndev)
                   RCR_EFFS | RCR_ENCF | RCR_ETS0 | RCR_ESF | 0x18000000, RCR);
 
        /* Set FIFO size */
-       ravb_write(ndev, TGC_TQP_AVBMODE1 | 0x00222200, TGC);
+       ravb_write(ndev, TGC_TQP_AVBMODE1 | 0x00112200, TGC);
 
        /* Timestamp enable */
        ravb_write(ndev, TCCR_TFEN, TCCR);