ice: fix adminq calls during remove
authorHenry Tieman <henry.w.tieman@intel.com>
Fri, 2 Aug 2019 08:25:24 +0000 (01:25 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 27 Aug 2019 06:54:29 +0000 (23:54 -0700)
The order of operations was incorrect in ice_remove(). The code would
try to use adminq operations after the adminq was disabled. This caused
all adminq calls to fail and possibly timeout waiting.

Signed-off-by: Henry Tieman <henry.w.tieman@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c

index 9371148dc4893c2dcade417c9ec66ffbf4654ba7..f029aee32913b225fb6a678385e02db6fe49c42e 100644 (file)
@@ -2633,9 +2633,9 @@ static void ice_remove(struct pci_dev *pdev)
                        continue;
                ice_vsi_free_q_vectors(pf->vsi[i]);
        }
-       ice_clear_interrupt_scheme(pf);
        ice_deinit_pf(pf);
        ice_deinit_hw(&pf->hw);
+       ice_clear_interrupt_scheme(pf);
        pci_disable_pcie_error_reporting(pdev);
 }