[PATCH] sil24: ignore non-error exception irqs
authorTejun Heo <htejun@gmail.com>
Thu, 6 Oct 2005 02:43:29 +0000 (11:43 +0900)
committerJeff Garzik <jgarzik@pobox.com>
Thu, 6 Oct 2005 09:51:24 +0000 (05:51 -0400)
01_sil24_ignore-non-error-exception-irqs.patch

Do not error-finish commands for non-error exception irqs -
just ignore them.  This is taken from Edward's driver.

Signed-off-by: Tejun Heo <htejun@gmail.com>
 sata_sil24.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/scsi/sata_sil24.c

index d8a2f5f04e821685a8e60faa5ba36c17b24943d4..571302dc48a34dfb2ba3048eb10407c239a0d75e 100644 (file)
@@ -489,12 +489,21 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat)
        u32 irq_stat, cmd_err, sstatus, serror;
 
        irq_stat = readl(port + PORT_IRQ_STAT);
+       writel(irq_stat, port + PORT_IRQ_STAT);         /* clear irq */
+
+       if (!(irq_stat & PORT_IRQ_ERROR)) {
+               /* ignore non-completion, non-error irqs for now */
+               printk(KERN_WARNING DRV_NAME
+                      "ata%u: non-error exception irq (irq_stat %x)\n",
+                      ap->id, irq_stat);
+               return;
+       }
+
        cmd_err = readl(port + PORT_CMD_ERR);
        sstatus = readl(port + PORT_SSTATUS);
        serror = readl(port + PORT_SERROR);
 
        /* Clear IRQ/errors */
-       writel(irq_stat, port + PORT_IRQ_STAT);
        if (cmd_err)
                writel(cmd_err, port + PORT_CMD_ERR);
        if (serror)