drivers/rtc/rtc-tps6586x.c: remove incorrect use of rtc_device_unregister
authorSachin Kamat <sachin.kamat@linaro.org>
Mon, 29 Apr 2013 23:20:09 +0000 (16:20 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 30 Apr 2013 01:28:33 +0000 (18:28 -0700)
Device managed functions do not need explicit freeing/unregistering.
Moreover in this case it was done using non-device managed function
which is incorrect.  Hence remove it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Laxman dewangan <ldewangan@nvidia.com>
Cc: Chiwoong Byun <woong.byun@samsung.com>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-tps6586x.c

index badfea491a93ccb8c2305548802873b5534f47df..459c2ffc95a6b3a9b59d6baf997949a0ac13ac0f 100644 (file)
@@ -289,15 +289,12 @@ static int tps6586x_rtc_probe(struct platform_device *pdev)
        if (ret < 0) {
                dev_err(&pdev->dev, "request IRQ(%d) failed with ret %d\n",
                                rtc->irq, ret);
-               goto fail_req_irq;
+               goto fail_rtc_register;
        }
        disable_irq(rtc->irq);
        device_set_wakeup_capable(&pdev->dev, 1);
        return 0;
 
-fail_req_irq:
-       rtc_device_unregister(rtc->rtc);
-
 fail_rtc_register:
        tps6586x_update(tps_dev, RTC_CTRL, 0,
                RTC_ENABLE | OSC_SRC_SEL | PRE_BYPASS | CL_SEL_MASK);