NFSv4: Convert struct nfs4_state to use refcount_t
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 2 Sep 2018 23:19:07 +0000 (19:19 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 30 Sep 2018 19:35:17 +0000 (15:35 -0400)
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs4_fs.h
fs/nfs/nfs4proc.c
fs/nfs/nfs4state.c

index 1b4737f4cac4cd51e6edd9d998655329c5f1731a..8d59c9655ec4800c95cde103c578aa1396826386 100644 (file)
@@ -188,7 +188,7 @@ struct nfs4_state {
        unsigned int n_wronly;          /* Number of write-only references */
        unsigned int n_rdwr;            /* Number of read/write references */
        fmode_t state;                  /* State on the server (R,W, or RW) */
-       atomic_t count;
+       refcount_t count;
 
        wait_queue_head_t waitq;
        struct rcu_head rcu_head;
index 10c20a5b075d9d3314673f520fe5b2dfcd04fb96..4da59bd53f98f01bfdbfbdb1a4c5c72b4d1b6bc3 100644 (file)
@@ -1777,7 +1777,7 @@ static struct nfs4_state *nfs4_try_open_cached(struct nfs4_opendata *opendata)
 out:
        return ERR_PTR(ret);
 out_return_state:
-       atomic_inc(&state->count);
+       refcount_inc(&state->count);
        return state;
 }
 
@@ -1849,7 +1849,7 @@ _nfs4_opendata_reclaim_to_nfs4_state(struct nfs4_opendata *data)
 update:
        update_open_stateid(state, &data->o_res.stateid, NULL,
                            data->o_arg.fmode);
-       atomic_inc(&state->count);
+       refcount_inc(&state->count);
 
        return state;
 }
@@ -1887,7 +1887,7 @@ nfs4_opendata_find_nfs4_state(struct nfs4_opendata *data)
                return ERR_CAST(inode);
        if (data->state != NULL && data->state->inode == inode) {
                state = data->state;
-               atomic_inc(&state->count);
+               refcount_inc(&state->count);
        } else
                state = nfs4_get_open_state(inode, data->owner);
        iput(inode);
@@ -1978,7 +1978,7 @@ static struct nfs4_opendata *nfs4_open_recoverdata_alloc(struct nfs_open_context
        if (opendata == NULL)
                return ERR_PTR(-ENOMEM);
        opendata->state = state;
-       atomic_inc(&state->count);
+       refcount_inc(&state->count);
        return opendata;
 }
 
index 7feac365038c01862b18dfff899902c5c3c13be0..6ca3bd0760730b5397bb7d6811d344f08cc51d1c 100644 (file)
@@ -655,7 +655,7 @@ nfs4_alloc_open_state(void)
        state = kzalloc(sizeof(*state), GFP_NOFS);
        if (!state)
                return NULL;
-       atomic_set(&state->count, 1);
+       refcount_set(&state->count, 1);
        INIT_LIST_HEAD(&state->lock_states);
        spin_lock_init(&state->state_lock);
        seqlock_init(&state->seqlock);
@@ -689,7 +689,7 @@ __nfs4_find_state_byowner(struct inode *inode, struct nfs4_state_owner *owner)
                        continue;
                if (!nfs4_valid_open_stateid(state))
                        continue;
-               if (atomic_inc_not_zero(&state->count))
+               if (refcount_inc_not_zero(&state->count))
                        return state;
        }
        return NULL;
@@ -743,7 +743,7 @@ void nfs4_put_open_state(struct nfs4_state *state)
        struct inode *inode = state->inode;
        struct nfs4_state_owner *owner = state->owner;
 
-       if (!atomic_dec_and_lock(&state->count, &owner->so_lock))
+       if (!refcount_dec_and_lock(&state->count, &owner->so_lock))
                return;
        spin_lock(&inode->i_lock);
        list_del_rcu(&state->inode_states);
@@ -1573,7 +1573,7 @@ restart:
                        continue;
                if (state->state == 0)
                        continue;
-               atomic_inc(&state->count);
+               refcount_inc(&state->count);
                spin_unlock(&sp->so_lock);
                status = ops->recover_open(sp, state);
                if (status >= 0) {