phylink: ensure we report link down when LOS asserted
authorRussell King <rmk+kernel@armlinux.org.uk>
Tue, 26 Dec 2017 23:15:12 +0000 (23:15 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Jan 2018 18:39:11 +0000 (13:39 -0500)
Although we disable the netdev carrier, we fail to report in the kernel
log that the link went down.  Fix this.

Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c

index 827f3f92560e711a17514055cb96adfbc05708f7..150cd95a6e1ed64555ee40687ce068b301004e29 100644 (file)
@@ -1429,9 +1429,8 @@ static void phylink_sfp_link_down(void *upstream)
        WARN_ON(!lockdep_rtnl_is_held());
 
        set_bit(PHYLINK_DISABLE_LINK, &pl->phylink_disable_state);
+       queue_work(system_power_efficient_wq, &pl->resolve);
        flush_work(&pl->resolve);
-
-       netif_carrier_off(pl->netdev);
 }
 
 static void phylink_sfp_link_up(void *upstream)