mfd: ab8500-debugfs: Pass the IRQF_ONESHOT flag
authorFabio Estevam <fabio.estevam@freescale.com>
Sat, 16 May 2015 18:42:15 +0000 (15:42 -0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 22 Jun 2015 11:25:27 +0000 (12:25 +0100)
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/ab8500-debugfs.c

index cdd6f3d63314c90d8ccbf1467ff7e58eff024e1c..0236cd7cdce4f3fbfca4002c62f706f55a6b0eed 100644 (file)
@@ -2885,7 +2885,7 @@ static ssize_t ab8500_subscribe_write(struct file *file,
        }
 
        err = request_threaded_irq(user_val, NULL, ab8500_debug_handler,
-                                  IRQF_SHARED | IRQF_NO_SUSPEND,
+                                  IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT,
                                   "ab8500-debug", &dev->kobj);
        if (err < 0) {
                pr_info("request_threaded_irq failed %d, %lu\n",