btrfs: check return value of btrfs_start_ioctl_transaction() properly
authorTsutomu Itoh <t-itoh@jp.fujitsu.com>
Mon, 24 Jan 2011 00:57:10 +0000 (00:57 +0000)
committerChris Mason <chris.mason@oracle.com>
Fri, 28 Jan 2011 21:40:37 +0000 (16:40 -0500)
btrfs_start_ioctl_transaction() returns ERR_PTR(), not NULL.
So, it is necessary to use IS_ERR() to check the return value.

Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
fs/btrfs/ioctl.c

index 04b4fb9144a9162143b64219dee370a29946b980..12dabe28cf5438c44c9f16ca27b746040dd26d9d 100644 (file)
@@ -2085,7 +2085,7 @@ static long btrfs_ioctl_trans_start(struct file *file)
 
        ret = -ENOMEM;
        trans = btrfs_start_ioctl_transaction(root, 0);
-       if (!trans)
+       if (IS_ERR(trans))
                goto out_drop;
 
        file->private_data = trans;