drm/bochs: Replace ttm_bo_unref with ttm_bo_put
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 31 Jul 2018 06:28:51 +0000 (08:28 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 30 Aug 2018 07:41:00 +0000 (09:41 +0200)
The function ttm_bo_put releases a reference to a TTM buffer object. The
function's name is more aligned to the Linux kernel convention of naming
ref-counting function _get and _put.

A call to ttm_bo_unref takes the address of the TTM BO object's pointer and
clears the pointer's value to NULL. This is not necessary in most cases and
sometimes even worked around by the calling code. A call to ttm_bo_put only
releases the reference without clearing the pointer.

The current behaviour of cleaning the pointer is kept in the calling code,
but should be removed if not required in a later patch.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: http://patchwork.freedesktop.org/patch/msgid/20180731062851.10812-1-tzimmermann@suse.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/bochs/bochs_mm.c

index 39cd08416773c551f8856e391efca98e2537e76a..c9c7097030ca6ef82949ab0fb11ce42b2480b042 100644 (file)
@@ -430,7 +430,7 @@ static void bochs_bo_unref(struct bochs_bo **bo)
                return;
 
        tbo = &((*bo)->bo);
-       ttm_bo_unref(&tbo);
+       ttm_bo_put(tbo);
        *bo = NULL;
 }