MIPS: KVM: Remove dead code of TLB index error in kvm_mips_emul_tlbwr()
authorDeng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Thu, 26 Jun 2014 19:11:40 +0000 (12:11 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 30 Jun 2014 14:52:04 +0000 (16:52 +0200)
It's impossible to fall into the error handling of the TLB index after
being masked by (KVM_MIPS_GUEST_TLB_SIZE - 1). Remove the dead code.

Reported-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/mips/kvm/emulate.c

index 1a6068892e66365a84d811a20716d97f4c171cee..fb3e8dfd1ff647263c0ca93a1d2ba6c5fdbd906b 100644 (file)
@@ -846,11 +846,6 @@ enum emulation_result kvm_mips_emul_tlbwr(struct kvm_vcpu *vcpu)
        get_random_bytes(&index, sizeof(index));
        index &= (KVM_MIPS_GUEST_TLB_SIZE - 1);
 
-       if (index < 0 || index >= KVM_MIPS_GUEST_TLB_SIZE) {
-               kvm_err("%s: illegal index: %d\n", __func__, index);
-               return EMULATE_FAIL;
-       }
-
        tlb = &vcpu->arch.guest_tlb[index];
 
        /*