bnxt: remove ndo_get_phys_port_name implementation
authorJiri Pirko <jiri@mellanox.com>
Thu, 28 Mar 2019 12:56:42 +0000 (13:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Mar 2019 19:55:30 +0000 (12:55 -0700)
Rely on the previously introduced fallback and let the core
call devlink in order to get the physical port name.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index eca36cac594e94ac617e2cece773310d18330951..35e34e23ba33fb397cc4496ae4ff7025b0b9c918 100644 (file)
@@ -10048,23 +10048,6 @@ static int bnxt_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh,
        return rc;
 }
 
-static int bnxt_get_phys_port_name(struct net_device *dev, char *buf,
-                                  size_t len)
-{
-       struct bnxt *bp = netdev_priv(dev);
-       int rc;
-
-       /* The PF and it's VF-reps only support the switchdev framework */
-       if (!BNXT_PF(bp))
-               return -EOPNOTSUPP;
-
-       rc = snprintf(buf, len, "p%d", bp->pf.port_id);
-
-       if (rc >= len)
-               return -EOPNOTSUPP;
-       return 0;
-}
-
 int bnxt_get_port_parent_id(struct net_device *dev,
                            struct netdev_phys_item_id *ppid)
 {
@@ -10122,7 +10105,6 @@ static const struct net_device_ops bnxt_netdev_ops = {
        .ndo_bridge_getlink     = bnxt_bridge_getlink,
        .ndo_bridge_setlink     = bnxt_bridge_setlink,
        .ndo_get_port_parent_id = bnxt_get_port_parent_id,
-       .ndo_get_phys_port_name = bnxt_get_phys_port_name,
        .ndo_get_devlink_port   = bnxt_get_devlink_port,
 };