xen-netback: fix possible format string flaw
authorKees Cook <keescook@chromium.org>
Wed, 11 Sep 2013 04:39:11 +0000 (21:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Sep 2013 21:20:03 +0000 (17:20 -0400)
This makes sure a format string cannot accidentally leak into the
kthread_run() call.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/interface.c

index 625c6f49cfba9923e80dc0834d49a6a6b870f1b3..77fee1d51fb2fc2cf47b218e9eba0ab4f56a1820 100644 (file)
@@ -406,7 +406,7 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
 
        init_waitqueue_head(&vif->wq);
        vif->task = kthread_create(xenvif_kthread,
-                                  (void *)vif, vif->dev->name);
+                                  (void *)vif, "%s", vif->dev->name);
        if (IS_ERR(vif->task)) {
                pr_warn("Could not allocate kthread for %s\n", vif->dev->name);
                err = PTR_ERR(vif->task);