perf trace: Drop thread refcount in trace__event_handler()
authorArnaldo Carvalho de Melo <acme@redhat.com>
Sat, 20 Oct 2018 12:27:52 +0000 (09:27 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 22 Oct 2018 15:37:52 +0000 (12:37 -0300)
We must pair:

   thread = machine__findnew_thread();

with thread__put(thread). Fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: c4191e55b874 ("perf trace: Show comm and tid for tracepoint events")
Link: https://lkml.kernel.org/n/tip-dkxsb8cwg87rmkrzrbns1o4z@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-trace.c

index 77b8748ad5edbfe149a86fb8ff3fc5b5ff9a36fe..589e0412652a5efe216706086e734d357c25552c 100644 (file)
@@ -2152,8 +2152,8 @@ newline:
                trace__fprintf_callchain(trace, sample);
        else if (callchain_ret < 0)
                pr_err("Problem processing %s callchain, skipping...\n", perf_evsel__name(evsel));
-       thread__put(thread);
 out:
+       thread__put(thread);
        return 0;
 }