powerpc/lpar/debug: Initialize flags before printing debug message
authorAlexey Kardashevskiy <aik@ozlabs.ru>
Tue, 9 Jan 2018 05:52:14 +0000 (16:52 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 27 Mar 2018 12:44:56 +0000 (23:44 +1100)
With enabled DEBUG, there is a compile error:
"error: ‘flags’ is used uninitialized in this function".

This moves pr_devel() little further where @flags are initialized.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/pseries/lpar.c

index d11f3c14c21e120be72a6095903afd97bf1a49ee..238b55fb80075e3350976965a55639ad2e6cb106 100644 (file)
@@ -306,14 +306,14 @@ static long pSeries_lpar_hpte_updatepp(unsigned long slot,
 
        want_v = hpte_encode_avpn(vpn, psize, ssize);
 
-       pr_devel("    update: avpnv=%016lx, hash=%016lx, f=%lx, psize: %d ...",
-                want_v, slot, flags, psize);
-
        flags = (newpp & 7) | H_AVPN;
        if (mmu_has_feature(MMU_FTR_KERNEL_RO))
                /* Move pp0 into bit 8 (IBM 55) */
                flags |= (newpp & HPTE_R_PP0) >> 55;
 
+       pr_devel("    update: avpnv=%016lx, hash=%016lx, f=%lx, psize: %d ...",
+                want_v, slot, flags, psize);
+
        lpar_rc = plpar_pte_protect(flags, slot, want_v);
 
        if (lpar_rc == H_NOT_FOUND) {