macvlan: propagate the mac address change status for lowerdev

The macvlan dev should propagate the return value of mac address change for
lower device in the passthru mode, instead of always return 0.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 346ad2ff39989d3da4cacc6ec1965ca882c475cd..ade1213e8a87b8c7f3c26e36de9cb8ed28e71941 100644 (file)
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -703,10 +703,8 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p)
        if (!is_valid_ether_addr(addr->sa_data))
                return -EADDRNOTAVAIL;
 
-       if (vlan->mode == MACVLAN_MODE_PASSTHRU) {
-               dev_set_mac_address(vlan->lowerdev, addr);
-               return 0;
-       }
+       if (vlan->mode == MACVLAN_MODE_PASSTHRU)
+               return dev_set_mac_address(vlan->lowerdev, addr);
 
        return macvlan_sync_address(dev, addr->sa_data);
 }