drm/i915: rc6 residency (fix the fix)
authorBen Widawsky <ben@bwidawsk.net>
Fri, 20 Apr 2012 18:50:01 +0000 (11:50 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 23 Apr 2012 07:30:14 +0000 (09:30 +0200)
Chris' fix for my 32b breakage was incorrect. do_div returns a
remainder. Go back to a divide macro which is more 32b friendly.

Tested on x86-64.

This has only been compile tested on 32b systems.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48756
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Sincere-apologies: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
[danvet: fixup 32bit compile-fail.]
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_sysfs.c

index f1b5108931feb5c8a52ca154a2c1e1f1a702c9c7..79f83445afa07c43d2d5109926bb4865b45b51de 100644 (file)
@@ -39,8 +39,8 @@ static u32 calc_residency(struct drm_device *dev, const u32 reg)
        if (!intel_enable_rc6(dev))
                return 0;
 
-       raw_time = I915_READ(reg) * 128ULL + 500;
-       return do_div(raw_time, 100000);
+       raw_time = I915_READ(reg) * 128ULL;
+       return DIV_ROUND_UP_ULL(raw_time, 100000);
 }
 
 static ssize_t