staging: rtl8188eu: simplify loop in rtl88eu_phy_iq_calibrate()
authorMichael Straube <straube.linux@gmail.com>
Fri, 7 Dec 2018 20:55:14 +0000 (21:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 12 Dec 2018 10:37:58 +0000 (11:37 +0100)
Zeroing the array result[m][n] and setting only the values at
even 'n's simplifies the code and slightly reduces object file
size.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/phy.c

index 482d48e003b7c6492ce6c9b7c31dabeed941138b..051cfbab78b16fc712cdd8a4d2cd485809e301b1 100644 (file)
@@ -1225,15 +1225,10 @@ void rtl88eu_phy_iq_calibrate(struct adapter *adapt, bool recovery)
                return;
        }
 
-       for (i = 0; i < 8; i++) {
-               result[0][i] = 0;
-               result[1][i] = 0;
-               result[2][i] = 0;
-               if ((i == 0) || (i == 2) || (i == 4)  || (i == 6))
-                       result[3][i] = 0x100;
-               else
-                       result[3][i] = 0;
-       }
+       memset(result, 0, sizeof(result));
+       for (i = 0; i < 8; i += 2)
+               result[3][i] = 0x100;
+
        final = 0xff;
        pathaok = false;
        pathbok = false;