drm/amd/display: Drive-by fixes for display_mode_vba
authorIlya Bakoulin <Ilya.Bakoulin@amd.com>
Fri, 3 May 2019 16:59:35 +0000 (12:59 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 22 Jun 2019 14:34:13 +0000 (09:34 -0500)
Fixes for the following:
- Incorrect pointer type (unsigned int instead of double)
- Incorrect DSC number of slices setting

Signed-off-by: Ilya Bakoulin <Ilya.Bakoulin@amd.com>
Reviewed-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h

index 4df885d17e69b64b66e601c097d770267bca0c88..a21608cd67eff0828884f7764db151afdbe4de26 100644 (file)
@@ -564,7 +564,6 @@ static void fetch_pipe_params(struct display_mode_lib *mode_lib)
                if (src->is_hsplit) {
                        for (k = j + 1; k < mode_lib->vba.cache_num_pipes; ++k) {
                                display_pipe_source_params_st *src_k = &pipes[k].pipe.src;
-                               display_output_params_st *dout_k = &pipes[k].dout;
 
                                if (src_k->is_hsplit && !visited[k]
                                                && src->hsplit_grp == src_k->hsplit_grp) {
@@ -579,8 +578,6 @@ static void fetch_pipe_params(struct display_mode_lib *mode_lib)
                                                mode_lib->vba.ViewportHeight[mode_lib->vba.NumberOfActivePlanes] +=
                                                                src_k->viewport_height;
 
-                                       mode_lib->vba.NumberOfDSCSlices[mode_lib->vba.NumberOfActivePlanes] +=
-                                                       dout_k->dsc_slices;
                                        visited[k] = true;
                                }
                        }
index 75028007095c191ea368c81bc3fb42a060f85e48..faf33e77e8d4db6c772233adc5212004bebacb6e 100644 (file)
@@ -455,7 +455,7 @@ struct vba_vars_st {
        double TotalNumberOfActiveOTG;
        double FECOverhead;
        double EffectiveFECOverhead;
-       unsigned int Outbpp;
+       double Outbpp;
        unsigned int OutbppDSC;
        double TotalDSCUnitsRequired;
        double bpp;
@@ -538,7 +538,7 @@ struct vba_vars_st {
        bool RequiresDSC[DC__VOLTAGE_STATES + 1][DC__NUM_DPP__MAX];
        unsigned int NumberOfDSCSlice[DC__VOLTAGE_STATES + 1][DC__NUM_DPP__MAX];
        double RequiresFEC[DC__VOLTAGE_STATES + 1][DC__NUM_DPP__MAX];
-       unsigned int OutputBppPerState[DC__VOLTAGE_STATES + 1][DC__NUM_DPP__MAX];
+       double OutputBppPerState[DC__VOLTAGE_STATES + 1][DC__NUM_DPP__MAX];
        double DSCDelayPerState[DC__VOLTAGE_STATES + 1][DC__NUM_DPP__MAX];
        bool ViewportSizeSupport[DC__VOLTAGE_STATES + 1];
        unsigned int Read256BlockHeightY[DC__NUM_DPP__MAX];