perf tools: Do not create kernel maps in sample__resolve()
authorJiri Olsa <jolsa@kernel.org>
Thu, 15 Feb 2018 12:26:34 +0000 (13:26 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 16 Feb 2018 17:25:59 +0000 (14:25 -0300)
There's no need for kernel maps to be allocated at this point - sample
processing.

We search for kernel maps using the kernel map_groups in machine::kmaps
which is static. If vmlinux maps for any reason still don't exist, the
search correctly fails because they are not in the map group.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180215122635.24029-9-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/event.c

index 4644e751a3e32d7af5ccded3757b2a603b8a75c0..f0a6cbd033cc7196afa30bb161bc545e95742bb2 100644 (file)
@@ -1588,17 +1588,6 @@ int machine__resolve(struct machine *machine, struct addr_location *al,
                return -1;
 
        dump_printf(" ... thread: %s:%d\n", thread__comm_str(thread), thread->tid);
-       /*
-        * Have we already created the kernel maps for this machine?
-        *
-        * This should have happened earlier, when we processed the kernel MMAP
-        * events, but for older perf.data files there was no such thing, so do
-        * it now.
-        */
-       if (sample->cpumode == PERF_RECORD_MISC_KERNEL &&
-           machine__kernel_map(machine) == NULL)
-               machine__create_kernel_maps(machine);
-
        thread__find_addr_map(thread, sample->cpumode, MAP__FUNCTION, sample->ip, al);
        dump_printf(" ...... dso: %s\n",
                    al->map ? al->map->dso->long_name :