kprobes: Remove pointless BUG_ON() from reuse_unused_kprobe()
authorMasami Hiramatsu <mhiramat@kernel.org>
Tue, 11 Sep 2018 10:20:11 +0000 (19:20 +0900)
committerIngo Molnar <mingo@kernel.org>
Wed, 12 Sep 2018 06:01:16 +0000 (08:01 +0200)
Since reuse_unused_kprobe() is called when the given kprobe
is unused, checking it inside again with BUG_ON() is
pointless. Remove it.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S . Miller <davem@davemloft.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Naveen N . Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/153666121154.21306.17540752948574483565.stgit@devbox
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/kprobes.c

index 231569e1e2c8fa827ed3c04d11170a88c84d2533..277a6cbe83db4a78456ecce2d6014c16d47b796b 100644 (file)
@@ -704,7 +704,6 @@ static void reuse_unused_kprobe(struct kprobe *ap)
 {
        struct optimized_kprobe *op;
 
-       BUG_ON(!kprobe_unused(ap));
        /*
         * Unused kprobe MUST be on the way of delayed unoptimizing (means
         * there is still a relative jump) and disabled.