staging: comedi: addi_apci_035: remove unused subdevices
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 14 Oct 2014 17:44:26 +0000 (10:44 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2014 07:48:53 +0000 (15:48 +0800)
Only allocate space for the subdevicess used by the driver. Remove all
the COMEDI_SUBD_UNUSED subdevices.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_035.c

index f2cc95aaa8a2f6ddc9786ec4375a64069cd40bfe..3eeb244ef8551e402917d8ab658e2191c75fd788 100644 (file)
@@ -117,7 +117,7 @@ static int apci035_auto_attach(struct comedi_device *dev,
                addi_eeprom_read_info(dev, pci_resource_start(pcidev, 0));
        }
 
-       ret = comedi_alloc_subdevices(dev, 7);
+       ret = comedi_alloc_subdevices(dev, 3);
        if (ret)
                return ret;
 
@@ -143,20 +143,8 @@ static int apci035_auto_attach(struct comedi_device *dev,
                s->type = COMEDI_SUBD_UNUSED;
        }
 
-       /*  Allocate and Initialise AO Subdevice Structures */
-       s = &dev->subdevices[1];
-       s->type = COMEDI_SUBD_UNUSED;
-
-       /*  Allocate and Initialise DI Subdevice Structures */
-       s = &dev->subdevices[2];
-       s->type = COMEDI_SUBD_UNUSED;
-
-       /*  Allocate and Initialise DO Subdevice Structures */
-       s = &dev->subdevices[3];
-       s->type = COMEDI_SUBD_UNUSED;
-
        /*  Allocate and Initialise Timer Subdevice Structures */
-       s = &dev->subdevices[4];
+       s = &dev->subdevices[1];
        if (devpriv->s_EeParameters.i_Timer) {
                s->type = COMEDI_SUBD_TIMER;
                s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
@@ -171,12 +159,8 @@ static int apci035_auto_attach(struct comedi_device *dev,
                s->type = COMEDI_SUBD_UNUSED;
        }
 
-       /*  Allocate and Initialise TTL */
-       s = &dev->subdevices[5];
-       s->type = COMEDI_SUBD_UNUSED;
-
        /* EEPROM */
-       s = &dev->subdevices[6];
+       s = &dev->subdevices[2];
        if (this_board->i_PCIEeprom) {
                s->type = COMEDI_SUBD_MEMORY;
                s->subdev_flags = SDF_READABLE | SDF_INTERNAL;