r8169: remove 1000/Half from supported modes
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 28 May 2019 16:43:46 +0000 (18:43 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 May 2019 04:42:48 +0000 (21:42 -0700)
MAC on the GBit versions supports 1000/Full only, however the PHY
partially claims to support 1000/Half. So let's explicitly remove
this mode.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index 64c25913a3263dd6d6f0dd36a600fce941d07332..261858e5a77dd7fdecbb761fdfb7dc166b003b4c 100644 (file)
@@ -6386,7 +6386,10 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
        if (ret)
                return ret;
 
-       if (!tp->supports_gmii)
+       if (tp->supports_gmii)
+               phy_remove_link_mode(phydev,
+                                    ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
+       else
                phy_set_max_speed(phydev, SPEED_100);
 
        phy_support_asym_pause(phydev);