firmware: add helper to unregister pm ops
authorLuis R. Rodriguez <mcgrof@kernel.org>
Mon, 20 Nov 2017 17:45:31 +0000 (09:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Nov 2017 10:07:00 +0000 (11:07 +0100)
This will be used later to unfold on error on init.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_class.c

index 4b57cf5bc81d15f47069832a5a631a9f254e567a..149413a376cf580c60819498fedd2b1f000ef86e 100644 (file)
@@ -1767,11 +1767,20 @@ static int fw_suspend(void)
 static struct syscore_ops fw_syscore_ops = {
        .suspend = fw_suspend,
 };
+
+static inline void unregister_fw_pm_ops(void)
+{
+       unregister_syscore_ops(&fw_syscore_ops);
+       unregister_pm_notifier(&fw_cache.pm_notify);
+}
 #else
 static int fw_cache_piggyback_on_request(const char *name)
 {
        return 0;
 }
+static inline void unregister_fw_pm_ops(void)
+{
+}
 #endif
 
 static void __init fw_cache_init(void)
@@ -1823,10 +1832,7 @@ static int __init firmware_class_init(void)
 
 static void __exit firmware_class_exit(void)
 {
-#ifdef CONFIG_PM_SLEEP
-       unregister_syscore_ops(&fw_syscore_ops);
-       unregister_pm_notifier(&fw_cache.pm_notify);
-#endif
+       unregister_fw_pm_ops();
        unregister_reboot_notifier(&fw_shutdown_nb);
 #ifdef CONFIG_FW_LOADER_USER_HELPER
        class_unregister(&firmware_class);