isdn: hisax: Fix pnp_irq's error checking for setup_hfcsx
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 16 Nov 2017 04:27:22 +0000 (09:57 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Nov 2017 13:31:16 +0000 (22:31 +0900)
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/hfc_sx.c

index d925f579bc802cf54aad8ec09cb0cf1f48dc94f2..4d3b4b2f2612231c345e751b642e691d5bd51c87 100644 (file)
@@ -1423,7 +1423,7 @@ int setup_hfcsx(struct IsdnCard *card)
                                        }
                                        card->para[1] = pnp_port_start(pnp_d, 0);
                                        card->para[0] = pnp_irq(pnp_d, 0);
-                                       if (!card->para[0] || !card->para[1]) {
+                                       if (card->para[0] == -1 || !card->para[1]) {
                                                printk(KERN_ERR "HFC PnP:some resources are missing %ld/%lx\n",
                                                       card->para[0], card->para[1]);
                                                pnp_disable_dev(pnp_d);