[IPV6]: Fix leak added by udp connect dst caching fix.
authorDavid S. Miller <davem@sunset.davemloft.net>
Mon, 3 Oct 2005 21:21:58 +0000 (14:21 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Mon, 3 Oct 2005 21:21:58 +0000 (14:21 -0700)
Based upon a patch from Mitsuru KANDA <mk@linux-ipv6.org>

Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/udp.c

index 6001948600f31bcbe622f18a9fc4461f6ef8531b..e4cad11f284ab9d2776070c729811d684df4e027 100644 (file)
@@ -852,10 +852,16 @@ do_append_data:
        else if (!corkreq)
                err = udp_v6_push_pending_frames(sk, up);
 
-       if (dst && connected)
-               ip6_dst_store(sk, dst,
-                             ipv6_addr_equal(&fl->fl6_dst, &np->daddr) ?
-                             &np->daddr : NULL);
+       if (dst) {
+               if (connected) {
+                       ip6_dst_store(sk, dst,
+                                     ipv6_addr_equal(&fl->fl6_dst, &np->daddr) ?
+                                     &np->daddr : NULL);
+               } else {
+                       dst_release(dst);
+               }
+       }
+
        if (err > 0)
                err = np->recverr ? net_xmit_errno(err) : 0;
        release_sock(sk);